Bug 853 - Poor reaction to no .options file for LIDAR Runs
Summary: Poor reaction to no .options file for LIDAR Runs
Status: RESOLVED FIXED
Alias: None
Product: DIRSIG4
Classification: Unclassified
Component: LIDAR (show other bugs)
Version: 4.4.0-release
Hardware: All All
: P5 normal
Assignee: Scott D. Brown
URL:
Depends on:
Blocks:
 
Reported: 2010-11-04 15:23 EDT by Scott D. Brown
Modified: 2011-10-18 13:45 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott D. Brown 2010-11-04 15:23:57 EDT
If you forget to have options for a LIDAR simulation, a bad allocation occurs.  Before this happens we should detect the issue and tell the user what is wrong.

Starting acquisition task #1
    Task Name: Single Pulse
    Task Description: A single pulse collection
    Sun position at the start of this task (scene relative):
        Sun is below horizon.
    Moon position at the start of this task (scene relative):
        63.6289 [degrees, declination]
        131.5104 [degrees, East of North]
        70.4598 [phase fraction]
        53.0505 [phase angle]
dirsig(26681,0x7fff70a5bc20) malloc: *** mmap(size=3616523134760943616) failed (error code=12)
*** error: can't allocate region
*** set a breakpoint in malloc_error_break to debug


DIRSIG ERROR: 
std::bad_alloc
Comment 1 Scott D. Brown 2010-12-03 16:14:33 EST
This came up again at the NGA training.  Is it possible for us to have the lidar maps setup by default and let the options override the settings somehow?
Comment 2 Adam Goodenough 2010-12-03 16:42:26 EST
Certainly seems possible, alternatively the gui could check for the options file if lidar is enabled.

(In reply to comment #1)
> This came up again at the NGA training.  Is it possible for us to have the
> lidar maps setup by default and let the options override the settings somehow?
Comment 3 Scott D. Brown 2011-01-05 21:14:23 EST
I still think a set of decent defaults would be more robust.
Comment 4 Adam Goodenough 2011-01-06 07:20:51 EST
Agreed, and we could always add a GUI check on top of it in the future.

(In reply to comment #3)
> I still think a set of decent defaults would be more robust.
Comment 5 Adam Goodenough 2011-10-18 13:45:15 EDT
The default photon max values have been set to 100k by default. The options file is no longer necessary (though desired). Note that the min bounce count is 0 by default so photon mapping is used by default for direct returns.